Lustre Code Reviews

From OpenSFS Wiki
Revision as of 17:21, 31 October 2014 by Morrone (talk | contribs) (Created page with "One of the most important tools for maintaining software code quality is the peer review process. When you review potential Lustre code changes on the [http://review.whamclou...")
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to navigation Jump to search

One of the most important tools for maintaining software code quality is the peer review process. When you review potential Lustre code changes on the review system, you are taking part in an essential part of the software development process.

Code reviews are not just about making pretty code and running a spell checker. Software quality can be divided into two areas: Source Code Quality and Product Quality. Source Code Quality aims to make the source more readable and presumably maintainable. Product Quality strives to make the running binary meet expectations, be stable, and be fault resistant. Code reviews need to enforce quality expectations in both areas.

Some expectations that we have of persons performing Lustre code reviews include:

  • Thing 1
  • Thing 2