LWG Minutes 2014-11-05 - Revision history

Morrone: /* Agenda */

2014-12-02T03:11:24Z

Agenda

← Older revision		Revision as of 19:11, 1 December 2014
Line 3:		Line 3:
	== Agenda ==		== Agenda ==

	* SC'14 LWG Meeting* Board Motions (see below)* Lustre code review guidelines/checklist (http://wiki.opensfs.org/Lustre_Code_Reviews)		* SC'14 LWG Meeting
			* Board Motions (see below)
			* Lustre code review guidelines/checklist (http://wiki.opensfs.org/Lustre_Code_Reviews)

	=== Board Motions ===		=== Board Motions ===
	Motion:		Motion:

Morrone: /* Code review guidlines */

2014-12-02T03:11:00Z

Code review guidlines

← Older revision		Revision as of 19:11, 1 December 2014
Line 50:		Line 50:
	Talk about develper resources at SC		Talk about develper resources at SC

	== Code review ~~guidlines~~ ==		== Code review guidelines ==

	Adnreas - definitely huge topic		Adnreas - definitely huge topic
	some pages on hpdd wiki, most lean toward code style		some pages on hpdd wiki, most lean toward code style
	back in CFS days had checklists for design reviews		back in CFS days had checklists for design reviews
	e.g. was scalability considered?, protocol compatibility?		e.g. was scalability considered?, protocol compatibility?

	Poor docs about ~~funtional~~ code inspection		Poor docs about functional code inspection
	Low level inspection checklist would be useful		Low level inspection checklist would be useful

Morrone: /* Board Motions */

2014-12-02T03:10:24Z

Board Motions

← Older revision		Revision as of 19:10, 1 December 2014
Line 6:		Line 6:
	=== Board Motions ===		=== Board Motions ===
	Motion:		Motion:

	To task the LWG to organize a developers day to be held to share expertise in a Lustre development. The LWG will provide the BoD with a a proposed agenda, venue, dates, communication strategy and budget to include any contracted expertise in the Lustre development community to facilitate a successful event.		To task the LWG to organize a developers day to be held to share expertise in a Lustre development. The LWG will provide the BoD with a a proposed agenda, venue, dates, communication strategy and budget to include any contracted expertise in the Lustre development community to facilitate a successful event.

	Motion:		Motion:
	To task the LWG to provide an update on Lustre stabilization efforts and proposed next steps including any authorizations they require to move forward.
			To task the LWG to provide an update on Lustre stabilization efforts and proposed next steps including any authorizations they require to move forward.

	== Attendance ==		== Attendance ==

Morrone: Created page with "Category:LWG == Agenda == * SC'14 LWG Meeting* Board Motions (see below)* Lustre code review guidelines/checklist (http://wiki.opensfs.org/Lustre_Code_Reviews) === Board..."

2014-12-02T03:09:58Z

Created page with "Category:LWG == Agenda == * SC'14 LWG Meeting* Board Motions (see below)* Lustre code review guidelines/checklist (http://wiki.opensfs.org/Lustre_Code_Reviews) === Board..."

New page

[[Category:LWG]]

== Agenda ==

* SC'14 LWG Meeting* Board Motions (see below)* Lustre code review guidelines/checklist (http://wiki.opensfs.org/Lustre_Code_Reviews)
=== Board Motions ===
Motion:
To task the LWG to organize a developers day to be held to share expertise in a Lustre development. The LWG will provide the BoD with a a proposed agenda, venue, dates, communication strategy and budget to include any contracted expertise in the Lustre development community to facilitate a successful event.
Motion:
To task the LWG to provide an update on Lustre stabilization efforts and proposed next steps including any authorizations they require to move forward.

== Attendance ==

* Richard Henwood (Intel)
* James Simmons (ORNL)
* Sebastien (Bull)
* Cory Spitz (Cray)
* Paul Sathis (Intel)
* Peter Jones (Intel)
* Colin Faber (Seagate)
* Ruth Klundt (Sandia)
* Andreas Dilger (Intel)

== SC'14 Meeting reminder ==

Tuesday November 18, 2:15-3:30pm Central

== Board Motions ==

=== Developer day ===

Cray, Intel locals

=== Lustre stability ===

Andreas - some code cleanup for layout
fault injection for lnet, message dropping
Andreas worried that throwing code away and rewriting it will just create more bugs (CLIO)

Colin to follow up on Seagate areas "shouldn't be protocol documneted, just rewritten"

Chris -

Adnreas - should ask Intel guys, which parts lousy, difficult to understand

Talk about develper resources at SC

== Code review guidlines ==

Adnreas - definitely huge topic
some pages on hpdd wiki, most lean toward code style
back in CFS days had checklists for design reviews
e.g. was scalability considered?, protocol compatibility?

Poor docs about funtional code inspection
Low level inspection checklist would be useful

Formal code review template suggested

Andreas - Is there appetite for more code commenting?
LOD, OSD, OSP

trouble areas needing commenting - ptlrpc

talk of rewriting or restructuring ptlrpc, but documentation (AT, replay, resend)
would be beneficial. lots of subtle interactions in there

Richard

Peter brought up LU-4134, Colin to bring up with team

James 2.8 - ldiskfs patches, disagreement about sharing patches, each has own set of patches
no sharing, some thing there should be sharing. Yang Shen doesn't like sharing idea

Peter - rhel6.6, sles12, switch to sles12 for lustre 2.7?